-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split view with meta boxes even with legacy canvas (#66706) #68228
base: wp/6.7
Are you sure you want to change the base?
Conversation
* Split view with meta boxes with non-iframed canvas * Fix scrolling of device previews * Consolidate styles and add comments * Do the same thing without adding a prop to BlockCanvas * Fix horizontal overflow of device previews Co-authored-by: stokesman <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: jartes <[email protected]> Co-authored-by: bph <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: MadtownLems <[email protected]>
Size Change: +120 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compared the diff with that of the original PR and only spotted one thing. I tested and found no other problems.
@@ -389,7 +389,8 @@ function VisualEditor( { | |||
{ | |||
'has-padding': isFocusedEntity || enableResizing, | |||
'is-resizable': enableResizing, | |||
'is-iframed': shouldIframe, | |||
'is-iframed': ! disableIframe, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this should be unchanged:
'is-iframed': ! disableIframe, | |
'is-iframed': shouldIframe, |
Otherwise, this class will be absent for device previews which are indeed iframed.
For reference in trunk it was changed in #65887 and that was not backported for 6.7.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
What?
Backports #66706 to
wp/6.7
for WP 6.7.2 release.