Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split upload into verbs and nouns #68227

Merged
merged 6 commits into from
Dec 23, 2024
Merged

split upload into verbs and nouns #68227

merged 6 commits into from
Dec 23, 2024

Conversation

timse201
Copy link
Contributor

Upload can be used as a noun or verb. Currently we have only 1 string to translate. It should be split up. We did it in the past and marked them as buttons, verbs and nouns etc.

props go to @wpgerd for the report

Trac ticket: https://core.trac.wordpress.org/ticket/62732#ticket

Copy link

github-actions bot commented Dec 22, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: timse201 <[email protected]>
Co-authored-by: talldan <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 22, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @timse201! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@talldan talldan added Internationalization (i18n) Issues or PRs related to internationalization efforts [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement. labels Dec 23, 2024
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @timse201.

This looks good to me. There were some missing imports for the _x function but I've added a commit for those.

It should be ready to merge when all the automated tests pass.

@timse201
Copy link
Contributor Author

Thank you

@talldan talldan merged commit 0fb8403 into WordPress:trunk Dec 23, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 23, 2024
@timse201 timse201 deleted the patch-1 branch December 23, 2024 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Media Anything that impacts the experience of managing media First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository Internationalization (i18n) Issues or PRs related to internationalization efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants