Slot: use layout effect and update Cover block unit tests #68176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in cf437e1. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12433952853
|
tyxla
approved these changes
Dec 20, 2024
mirka
approved these changes
Dec 20, 2024
jsnajdr
force-pushed
the
update/slot-effect
branch
from
3bcee0a to
cf437e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spinoff from #68056. In the base
Slotimplementation, register the slot in a layout effect instead of a normal effect. Other parts of the slot/fill library also use layout effects. And it's a good idea to settle all the registration and rendering in layout effects: then the first actual paint will not paint empty slots when fills are already registered.Interestingly this breaks some Cover block unit tests, because of some subtle timing changes I don't understand. Turns out the block sidebar content is not update immediately when the block is selected, but a little bit later, and it's not caught by the RTL
renderfunction. The tests are easily fixed by changing some syncgetBy*calls toawait findBy*.