-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wp-env: Added phpMyAdmin and multisite support to the documentation #68125
base: trunk
Are you sure you want to change the base?
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in c092597. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12424261880
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much, @t-hamano! I've preemptively approved this but left some suggestions.
Alternatively, you can use phpMyAdmin to access the mySQL database. To enable access to phpMyAdmin, add the `WP_ENV_PHPMYADMIN_PORT` environment variable to the command: | ||
|
||
```bash | ||
WP_ENV_PHPMYADMIN_PORT=9000 npm run wp-env start | ||
``` | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- I'd mention this earlier in the section, maybe even right after the heading. The point of phpMyAdmin is to be the "default easy" option.
- I'd also include the config option and not just the env var, since that could be a more convenient "always on" option.
A note in passing: this is the first time I see the mention of Sequel Ace, and while I appreciate the intention it's a little strange to recommend a proprietary tool that (as far as I could tell) only runs on macOS. Perhaps now with phpMyAdmin readily available we could drop the mention of Sequel Ace? I'll defer to @getdave, author of the change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps now with phpMyAdmin readily available we could drop the mention of Sequel Ace?
I agree with this too.
Co-authored-by: Miguel Fonseca <[email protected]>
Co-authored-by: Miguel Fonseca <[email protected]>
Co-authored-by: Miguel Fonseca <[email protected]>
Related to #67588, #67845
What?
Add documentation for the new support recently added in the env package (phpMyAdmin, Multisite).
Why?
For developers
How?
I have updated two files that I thought needed updating. Any suggestions for wording corrections are welcome.
Testing Instructions
None