Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix indentation in the upload-media tsconfig #68083

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

afercia
Copy link
Contributor

@afercia afercia commented Dec 18, 2024

Follow-up to #66290

Cc @swissspidy @sarthaknagoshe2002

What?

Indentation with spaces introduced in #66290 is causing problems for other PRs because the pre-commit hook auto-fixes them resulting in unrelated changed file.

Why?

Indentation should use tabs.

How?

Fixes the indentation

Testing Instructions

N/A

Testing Instructions for Keyboard

Screenshots or screencast

Before After

@afercia afercia added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 18, 2024
Copy link

github-actions bot commented Dec 18, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: afercia <[email protected]>
Co-authored-by: swissspidy <[email protected]>
Co-authored-by: sarthaknagoshe2002 <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@swissspidy swissspidy enabled auto-merge (squash) December 18, 2024 09:25
@sarthaknagoshe2002
Copy link
Contributor

Thanks for the quick PR @afercia 😇

@swissspidy swissspidy disabled auto-merge December 18, 2024 09:31
@swissspidy swissspidy enabled auto-merge (squash) December 18, 2024 09:31
Copy link

Flaky tests detected in 9fb8579.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12389934523
📝 Reported issues:

@swissspidy swissspidy merged commit 53dc79e into trunk Dec 18, 2024
67 checks passed
@swissspidy swissspidy deleted the fix/upload-media-tsconfig-indentation branch December 18, 2024 09:55
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants