Badge component: Fix Storybook url link #68077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Developer Documentation
t-hamano
commented
Dec 18, 2024
| @@ -48,4 +48,3 @@ export function generateMarkdownPropsJson( props, { headingLevel = 2 } = {} ) { | |||
|
|
|||
| return [ { [ `h${ headingLevel }` ]: 'Props' }, ...propsJson ]; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
This change is to fix a warning in prettier (Two newlines).
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
tyxla
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fix an issue where the Storybook link in the
Badgecomponent README was not linking to an actual story:426f038b3403e90168cd5227bcee5686.mp4
Why?
This is because the URL rules are different when automatically generating a README and when using Storybook.
How?
By adding an
idfield to the storybook meta, change the story URL of theBadgecomponent as follows:Testing Instructions
Testing Instructions for Keyboard
npm run storybook:devBadgecomponent should behttp://localhost:50240/?path=/docs/components-badge--docs.