Do not control Nav Link item focus when focus within sidebar control #68044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
getdave
commented
Dec 17, 2024
Comment on lines
-504
to
+514
| ! isLabelFieldFocused && ( | ||
| ! isControlFieldFocused && ( |
There was a problem hiding this comment.
@ellatrix Is it expected that we need to conditionally render RichText like this to avoid it "stealing" focus?
|
Size Change: +7 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 8bc85d6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12370769846
|
Open
6 tasks
|
I believe we can just remove the fallback selectPreviousBlock to fix this instead. #68063 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Avoids controlling the focus when closing the Link UI if the current focus is within a sidebar control.
Fixes #68035
Why?
Currently on trunk when creating a new Link and then focusing on one of the inspector control sidebar fields focus is "stolen". See the Issue where this is detailed.
This is caused by:
Both Issues overlay and are related.
How?
This PR patches the current problem by extending the state which tracks whether the label field has focus to include all of the inspector control fields. This allows us to disable the
RichTextfrom rendering and stealing focus if a sidebar field is focused by the user.This PR also adds a conditional which exits early from any focus management logic if the focus is currently within any of the sidebar fields.
I will say that it seems extreme that we need to control the
RichTextin this manner. Moreover, I'd love to understand more about why the fallback to select the previous block is necessary.Testing Instructions
/in the canvas.Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-12-17.at.10-08-34.mp4