Allow replace operation on empty default block in Zoom Out #68026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Bug
getdave
requested review from
draganescu,
scruffian,
jeryj,
MaggieCabrera and
ajlende
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Noting that I think we need to follow up with this to:
|
|
Size Change: -43 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
This was referenced Dec 16, 2024
draganescu
reviewed
Dec 16, 2024
| if ( isZoomOut() && operation !== 'insert' ) { | ||
| const isTargetIndexEmptyDefaultBlock = | ||
| operation === 'replace' && | ||
| blocksData[ targetIndex ]?.isUnmodifiedDefaultBlock; |
There was a problem hiding this comment.
It's a bit confusing to read operation === 'replace' and later operation !== 'insert' and also why does the kind of operation determine if isTargetIndexEmptyDefaultBlock, as it feels the isUnmodifiedDefaultBlock flag should be enough.
There was a problem hiding this comment.
You know what I think we might be able to remove the operation check like you suggest.
There was a problem hiding this comment.
✅ Does it work for you?
draganescu
approved these changes
Dec 16, 2024
getdave
deleted the
fix/zoom-out-allow-pattern-drop-empty-default-block
branch
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…#68026) * Allow replace operation on empty default block in Zoom Out * Remove operation type from conditional check Co-authored-by: getdave <[email protected]> Co-authored-by: draganescu <[email protected]>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…#68026) * Allow replace operation on empty default block in Zoom Out * Remove operation type from conditional check Co-authored-by: getdave <[email protected]> Co-authored-by: draganescu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Allows for drag and drop of Patterns in Zoom Out if the only block is an unmodified default block (normally
core/paragraph).Fixes part of #67564
Why?
Currently on
trunkwhen editing a Page in the Site Editor you can end up with a placeholdercore/paragraphblock in witin thecore/post-contentblock.When in Zoom Out you drag and drop a Pattern onto this block there is no drop zone rendered.
This PR fixes that to show the drop zone. It also works if there is an unmodified default block anywhere within the block list which can happen if you click a pattern and insert into an empty page as the default block remains.
How?
Allows for a
replaceoperation to be handled in Zoom Out but only if the block being replaced is an unmodified default block (i.e.core/paragraph).This in turn allows the zoom out separator to be rendered.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2024-12-16.at.12-27-20.mp4