Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Add JSDoc and story file for block-compare #68004

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

miminari
Copy link
Member

@miminari miminari commented Dec 15, 2024

What?

part of #67165

Why?

How?

BlockCompare does not have a convertor by itself, so I tried to use it as a story that only displays a dummy block object.

Testing Instructions

npm run storybook:dev and please check the BlockCompare story.

Testing Instructions for Keyboard

Screenshots or screencast

スクリーンショット 2024-12-18 23 33 25

@t-hamano t-hamano added [Type] Developer Documentation Documentation for developers Storybook Storybook and its stories for components labels Dec 16, 2024
@miminari miminari marked this pull request as ready for review December 18, 2024 14:37
@miminari miminari requested a review from ellatrix as a code owner December 18, 2024 14:37
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: miminari <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@miminari miminari removed the request for review from ellatrix December 18, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Storybook Storybook and its stories for components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants