Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table of Contents Block: Refactor settings panel to use ToolsPanel #67964

Merged
merged 5 commits into from
Jan 13, 2025
Merged

Table of Contents Block: Refactor settings panel to use ToolsPanel #67964

merged 5 commits into from
Jan 13, 2025
+38 −19

Conversation

Sukhendu2002
Copy link
Contributor

Part of: #67813

What?

Refactored Table of Contents Block code to include ToolsPanel instead of PanelBody.

Screenshots or screencast

Before After
image image

@Sukhendu2002 Sukhendu2002 marked this pull request as ready for review December 13, 2024 10:27
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 13, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Sukhendu2002 <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Sukhendu2002 Sukhendu2002 mentioned this pull request Dec 13, 2024
Open
@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Table of contents (experimental) Affects the Table of contents Block labels Dec 13, 2024
@fabiankaegy fabiankaegy linked an issue Dec 13, 2024 that may be closed by this pull request
Refactor "Settings" panel of Table of Contents block to use ToolsPanel instead of PanelBody #67928
Closed
@fabiankaegy fabiankaegy self-requested a review December 13, 2024 23:09
@fabiankaegy
Copy link
Member

@Sukhendu2002 can you resolve the conflict in this PR ? :)

@Sukhendu2002
Copy link
Contributor Author

Hi @fabiankaegy, I resolved the conflicts, Feel free to take a look whenever you have time. Thanks!

t-hamano
t-hamano approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I left just one suggestion and it is working as expected 👍

packages/block-library/src/table-of-contents/edit.js Outdated Show resolved Hide resolved
@Sukhendu2002
Copy link
Contributor Author

@t-hamano thanks for the feedback, I have updated the PR accordingly.

@t-hamano t-hamano merged commit 1284a26 into WordPress:trunk Jan 13, 2025
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ZebulanStanphill ZebulanStanphill Awaiting requested review from ZebulanStanphill ZebulanStanphill is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy

Assignees
No one assigned
Labels
[Block] Table of contents (experimental) Affects the Table of contents Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 20.1
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Table of Contents block to use ToolsPanel instead of PanelBody
3 participants
@Sukhendu2002 @fabiankaegy @t-hamano