Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Author Name: Refactor settings panel to use ToolsPanel #67953

Merged
merged 3 commits into from
Jan 13, 2025
Merged

Author Name: Refactor settings panel to use ToolsPanel #67953

merged 3 commits into from
Jan 13, 2025

Conversation

SainathPoojary
Copy link
Contributor

@SainathPoojary SainathPoojary commented Dec 13, 2024 •
edited
Loading

Issue: #67942
Part of: #67813

What?

Refactored the Author Name Block to use ToolsPanel instead of PanelBody.

Screenshots

Before After
Before After

@SainathPoojary SainathPoojary mentioned this pull request Dec 13, 2024
Open
@fabiankaegy fabiankaegy linked an issue Dec 13, 2024 that may be closed by this pull request
Refactor "Settings" panel of Author Name block to use ToolsPanel instead of PanelBody #67942
Closed
@fabiankaegy fabiankaegy added [Type] Enhancement A suggestion for improvement. [Block] Author Name Affects the Author Name Block labels Dec 13, 2024
@SainathPoojary SainathPoojary marked this pull request as ready for review December 16, 2024 10:19
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 16, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

t-hamano
t-hamano approved these changes Jan 13, 2025
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is working as expected.
Since it's been almost a month since this PR was submitted, can you rebase it just to be sure and see if it passes all the CIs?

@t-hamano t-hamano added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 13, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Jan 13, 2025
@t-hamano t-hamano merged commit 88b4e1d into WordPress:trunk Jan 13, 2025
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.1 milestone Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-hamano t-hamano t-hamano approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees
No one assigned
Labels
[Block] Author Name Affects the Author Name Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 20.1
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Author Name block to use ToolsPanel instead of PanelBody
3 participants
@SainathPoojary @t-hamano @fabiankaegy