Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login/Logout: Refactor settings panel to use ToolsPanel #67909

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

Infinite-Null
Copy link
Contributor

@Infinite-Null Infinite-Null commented Dec 13, 2024

Part of: #67813

What?

Refactored Login/Logout Block code to include ToolsPanel instead of PanelBody.

Screenshots:

Before After
image image

@Infinite-Null Infinite-Null marked this pull request as ready for review December 13, 2024 07:36
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Member

@fabiankaegy fabiankaegy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works as expected :) Thanks 🚀

CleanShot.2024-12-13.at.15.55.24.mp4

@fabiankaegy fabiankaegy merged commit bae6236 into WordPress:trunk Dec 13, 2024
68 of 71 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 13, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…tead of PanelBody (WordPress#67909)

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
…tead of PanelBody (WordPress#67909)

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: fabiankaegy <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Login/out Affects the Login/out Block [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor "Settings" panel of Login/Logour block to use ToolsPanel instead of PanelBody
2 participants