Storybook: Upgrade to the latest version (v8.4.7) #67863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +103 B (+0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 5a95716. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12293569889
|
ciampo
reviewed
Dec 12, 2024
| @@ -155,3 +155,5 @@ export const parameters = { | |||
| }, | |||
| sourceLinkPrefix: 'https://github.com/WordPress/gutenberg/blob/trunk/', | |||
| }; | |||
|
|
|||
| export const tags = [ 'autodocs' ]; | |||
There was a problem hiding this comment.
The migrations docs suggesting adding a default export, is there a reason why we're not following that suggestion and opting for a named export instead? Could this ever stop working in the future?
There was a problem hiding this comment.
The auto migrator didn't have a problem catching that and working with it. I think it shouldn't be an issue. If it does, we'll find out quickly enough.
ciampo
approved these changes
Dec 12, 2024
|
Thanks for taking a look and testing 🙇♂️
Yes! Might motivate us to further adopt tags in our stories.
Yup, those are pre-existing, and I'd love to clean them all soon. One step at a time! |
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
* Bump dependencies to v8.1.11 * 8.1: Move autodocs to preview tags * Bump dependencies to v8.2.10 * Bump dependencies to v8.3.7 * Bump dependencies to v8.4.7 Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Upgrading Storybook to the latest version (v8.4.7).
Why?
We've been stuck on Storybook 7.x for a while. In #67574 we upgraded to v8.0, and this PR brings Storybook to the latest version.
How?
It's mostly bumping the versions, which results in a major dependency cleanup (see #67840 that attempted to do parts of that).
The only non-dependency change is the deprecation of
autodocs, see https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#mainjs-docsautodocs-is-deprecatedTesting Instructions
Testing Instructions for Keyboard
Same
Screenshots or screencast
None