Fix: Script with glob option doesn't work on Windows #67862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Build Tooling
|
Size Change: 0 B Total Size: 1.83 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
It's one of those moment where I appreciate the backward compatibility policy followed by WordPress 😄 I'll give it a spin on macOS. |
sirreal
approved these changes
Dec 12, 2024
|
Thanks for the review! I would like to merge this PR as it is working in my environment 👍 |
|
I'm happy to test with |
|
Everything works correctly on my end when using scripts that execute |
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
Co-authored-by: t-hamano <[email protected]> Co-authored-by: sirreal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #67708, #67829, #67833
What?
I have found that scripts with the glob option, although they don't cause errors, don't actually delete the files on Windows OS.
Why?
Perhaps single quotes have a special meaning in the Windows OS shell.
How?
To eliminate these errors, I use escaped double quotes in all commands.
For thefixtures:cleanscript, I tried not to use regular expressions so that it would work on Windows OS.Testing Instructions
Note that the order in which files are displayed by the ls command may vary depending on your operating system.
clean:package-types, clean:packages
print
print
print
fixtures:clean
print
print