Dataviews List layout: do not use grid role on a ul element.
#67849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgefilipecosta
added
the
[Type] Bug
|
Size Change: +48 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
oandregal
added
the
[Focus] Accessibility (a11y)
oandregal
changed the title
ul element.
oandregal
approved these changes
Dec 13, 2024
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…ress#67849) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: oandregal <[email protected]>
yogeshbhutkar
pushed a commit
to yogeshbhutkar/gutenberg
that referenced
this pull request
Dec 18, 2024
…ress#67849) Co-authored-by: jorgefilipecosta <[email protected]> Co-authored-by: oandregal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on the dataviews list view we are rendering a grid role in an ul element (and a row role on a list element). The ul element does not support a grid role see https://developer.mozilla.org/en-US/docs/Web/HTML/Element/ul (permitted roles are directory, group, listbox, menu, menubar, none, presentation, radiogroup, tablist, toolbar, tree).
This PR fixes the issue by using a div element instead of ul and li.