Inline commenting: Add associated block client ids to comment object #67630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +45 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in ea0d195. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12181143717
|
ellatrix
reviewed
Dec 17, 2024
| const updatedResult = result.map( ( item ) => ( { | ||
| ...item, | ||
| reply: [ ...item.reply ].reverse(), | ||
| clientId: blockCommentIdMap.get( item.id )?.clientID, |
There was a problem hiding this comment.
Where is this being used? I don't see it here
There was a problem hiding this comment.
This will help to exclude the logic implemented here to retrieve the clientIds related to commentIds. Also, It will help on my next PR regarding comment board alignment to block position for the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Discussed on #66873 (comment)
Why?
Add associated block client ids to comment object to reduce logic and complexity, Block client id are required through out the commenting functionality.
Testing Instructions
No visual testing required.