-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packages: Extract dom package and make it maintained with Lerna #6758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
{ | ||
selector: 'ImportDeclaration[source.value=/^dom$/]', | ||
message: 'Use @wordpress/dom as import path instead.', | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Possible merge conflict with #6756 when it comes time to merge |
9df1f7d
to
2e2e857
Compare
Added deprecation for all dom utils in |
There are packages which depend on The same applies to |
c367c49
to
2e2e857
Compare
Description
Related issues: #3955, #6594.
This PR extract new
dom
package which contains all DOM utils.Open question
Question is if we should also provide
deprecation
message for all moved functions from@wordpress/utils
?How has this been tested?
Manually:
node_modules
folder.npm install
npm test
npm run dev
npm run build
npm run package-plugin
Checklist: