Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storybook: Remove unnecessary feature flags #67576

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Storybook: Remove unnecessary feature flags #67576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions storybook/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,6 @@ module.exports = {
name: '@storybook/react-webpack5',
options: {},
},
features: {
babelModeV7: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Babel mode is the default since v7, see https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#babel-mode-v7-exclusively

emotionAlias: false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're using Emotion 11 so this is not necessary, and the flag was removed anyway, see https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#70-feature-flags-removed

storyStoreV7: true,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unnecessary, since it's enabled by default since Storybook v7, see https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#storystorev7-enabled-by-default

},
docs: {
autodocs: true,
},
Expand Down
Loading