Site Editor Sidebar: remove hasGlobalStyleVariations condition for the Styles nav item
#67545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and no longer just the variations. For this reason it's okay to remove the condition. Also, make the props consistent in the main component.
ramonjd
added
[Type] Code Quality
ramonjd
requested review from
youknowriad,
talldan,
tellthemachines and
jorgefilipecosta
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -32 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
Thanks for testing @tellthemachines I installed the theme onyxpulse, which doesn't have variations. |
tellthemachines
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
I know what happened, I tested trunk after #67537 was already merged 😄
LGTM!
ramonjd
deleted the
remove/edit-site-sidebar-styles-variations-condition
branch
ramonjd
added
the
Backport to Gutenberg RC
ramonjd
added
Backport to Gutenberg RC
|
Since this is just a code quality follow-up to #67537 and generates conflicts with 19.8, let's skip the backport to 19.8. Thanks for following up with the polishing, though! ❤️ |
priethor
removed
the
Backport to Gutenberg RC
|
Sorry, I forgot to remove the label. Thank you! |
im3dabasia
pushed a commit
to im3dabasia/gutenberg
that referenced
this pull request
Dec 4, 2024
…the Styles nav item (WordPress#67545) Co-authored-by: ramonjd <[email protected]> Co-authored-by: tellthemachines <[email protected]>
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
…the Styles nav item (#67545) Co-authored-by: ramonjd <[email protected]> Co-authored-by: tellthemachines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to #67537
cc @Mayank-Tripathi32
👋🏻
hasGlobalStyleVariationscondition to show the Styles menu item in the edit site sidebar.uidandtoprops toMainSidebarNavigationContentfor consistency and convenience.Why?
The sidebar navigation styles item now contains the global styles UI and no longer just the variations. For this reason it's okay to remove the condition.
Testing Instructions
Screenshots or screencast
Kapture.2024-12-04.at.10.54.14.mp4