Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix(navigation): navigation block delete warning double click fix. #67485

Conversation

creador-dev
Copy link
Contributor

@creador-dev creador-dev commented Dec 2, 2024

What?

This PR addresses an issue where users could accidentally create two navigation menus by double-clicking the "Create a new menu" button in an empty block.

Why?

How?

The DeletedNavigationWarning component has been updated:

  • Added a useState hook to manage the disabled state of the button.
  • Updated the button to disable immediately after the first click.
  • Included the accessibleWhenDisabled prop to ensure the button remains accessible when disabled.

Testing Instructions

  1. Open the Editor (Post/Page editor or Site Editor) in WordPress.
  2. Insert a Navigation Block into your content.
  3. Delete the Navigation Custom Post Type (CPT) that the block is using.
    • This can typically be done by navigating to the Appearance > Navigation section and deleting the menu associated with the block.
  4. Return to the editor, and observe that the "Create a new menu" prompt appears within the Navigation block.
  5. Quickly double-click the "Create a new menu" button.
  6. Verify that:
    • The button becomes disabled after the first click.
    • Only one navigation menu is created in the Appearance > Navigation section.
    • No duplicate menus are created, even with rapid double-clicking.

Testing Instructions for Keyboard

  1. Follow the steps above using only the keyboard:
    • Navigate to the "Create a new menu" button using the Tab key.
    • Press Enter or Space to activate the button.
  2. Confirm that the button disables after the first activation.
  3. Verify that no duplicate menus are created when the button is activated repeatedly using the keyboard.

Interacted Accounts

The following accounts have interacted with this PR and/or linked issues:

Copy link

github-actions bot commented Dec 2, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: creador-dev <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

github-actions bot commented Dec 2, 2024

Warning: Type of PR label mismatch

To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.

  • Type-related labels to choose from: [Type] Automated Testing, [Type] Breaking Change, [Type] Bug, [Type] Build Tooling, [Type] Code Quality, [Type] Copy, [Type] Developer Documentation, [Type] Enhancement, [Type] Experimental, [Type] Feature, [Type] New API, [Type] Task, [Type] Technical Prototype, [Type] Performance, [Type] Project Management, [Type] Regression, [Type] Security, [Type] WP Core Ticket, Backport from WordPress Core, Gutenberg Plugin.
  • Labels found: .

Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task.

Copy link

github-actions bot commented Dec 2, 2024

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @creador-dev! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Dec 2, 2024
@creador-dev creador-dev closed this Dec 2, 2024
@creador-dev creador-dev deleted the fix/navigation-block-delete-warning branch December 2, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant