-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Editor: Animate useScaleCanvas()
only when toggling zoomed out mode
#67481
Conversation
useScaleCanvas()
only when toggling zoomed out mode
Size Change: +9 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. Seems to fix the performance regression, let's see in the graph afterwards.
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…mode (WordPress#67481) Co-authored-by: tyxla <[email protected]> Co-authored-by: ellatrix <[email protected]>
…mode (#67481) Co-authored-by: tyxla <[email protected]> Co-authored-by: ellatrix <[email protected]>
What?
Fixes an error that occurs when navigating directly to block styles of a particular block in the site editor.
Alternative of #67375.
Why?
Just fixing an error that seems to have been introduced in #66917.
Found while testing #67199.
How?
We're only starting calculations for the zoomed out animation if the user actually toggled the zoomed out mode.
Previously, the calculations were running when attempting to "directly" load the page with styles of a particular block.
Testing Instructions
/wp-admin/site-editor.php?p=%2Fstyles§ion=%2Fblocks%2Fcore%252Fheading
directly (not by navigating to it)Testing Instructions for Keyboard
Same
Screenshots or screencast