Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FormFileUpload: Deprecate 36px default size #67438

Open
wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Conversation

mirka
Copy link
Member

@mirka mirka commented Nov 29, 2024

Part of #65751

What?

Deprecates the 36px default size on FormFileUpload.

Testing Instructions

  • Log deprecation warning
  • Update unit tests
  • Update Storybook (including all stories where the component is used)
  • Update code snippets (Storybook, JSDoc, READMEs, and any other Markdown docs)

@mirka mirka added [Type] Code Quality Issues or PRs that relate to code quality [Package] Components /packages/components Needs Dev Note Requires a developer note for a major WordPress release cycle labels Nov 29, 2024
@mirka mirka self-assigned this Nov 29, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also converted the README to an auto-generated one.

@mirka mirka marked this pull request as ready for review November 29, 2024 19:34
@mirka mirka requested a review from a team November 29, 2024 19:35
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: mirka <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Note Requires a developer note for a major WordPress release cycle [Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant