Remove use of contentOnly block editing mode for synced patterns
#67364
+2
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Bug
|
Size Change: 0 B Total Size: 1.82 MB ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I'll YOLO merge this so that the broken e2e tests in trunk are not blocking anyone, but I still encourage peer review/testing/feedback. |
michalczaplinski
pushed a commit
that referenced
this pull request
Dec 5, 2024
…67364) * Remove use of `contentOnly` block editing mode for synced patterns * Update unit tests ---- Co-authored-by: talldan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes the broken e2e tests in
trunk.Removes the use of
contentOnlymode for the synced pattern block.Why?
contentOnlymode removes some of the options from the block:It results in the block no longer being groupable, which caused an e2e test failure.
How?
The block now uses the default mode.
Testing Instructions
Also worth testing when the block is used as a section in Write Mode - the settings menu should have a reduced set of sections like any other section.
Screenshots or screencast
Before
After