Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CustomGradientPicker: Prepare Buttons for 40px default size #67286

Merged
merged 2 commits into from
Nov 26, 2024
Merged

CustomGradientPicker: Prepare Buttons for 40px default size #67286

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cb1c06
CustomGradientPicker: Prepare `Button`s for 40px default size
mirka Nov 25, 2024
3f833fe
Add changelog
mirka Nov 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@
- `SlotFill`: rewrite the `Slot` component from class component to functional ([#67153](https://github.com/WordPress/gutenberg/pull/67153)).
- `Menu.ItemHelpText`: Fix text wrapping to prevent unintended word breaks ([#67011](https://github.com/WordPress/gutenberg/pull/67011)).
- `BorderBoxControl`: Suppress redundant warnings for deprecated 36px size ([#67213](https://github.com/WordPress/gutenberg/pull/67213)).
- `CustomGradientPicker`: Prepare `Button`s for 40px default size ([#67286](https://github.com/WordPress/gutenberg/pull/67286)).

## 28.12.0 (2024-11-16)

Expand Down
2 changes: 2 additions & 0 deletions packages/components/src/custom-gradient-picker/gradient-bar/control-points.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ function ControlPointButton( {
aria-describedby={ descriptionId }
aria-haspopup="true"
aria-expanded={ isOpen }
__next40pxDefaultSize
className={ clsx(
'components-custom-gradient-picker__control-point-button',
{
Expand Down Expand Up @@ -349,6 +350,7 @@ function InsertPoint( {
} }
renderToggle={ ( { isOpen, onToggle } ) => (
<Button
__next40pxDefaultSize
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one other Button instance in this file is a link variant, so it doesn't need the prop.

aria-expanded={ isOpen }
aria-haspopup="true"
onClick={ () => {
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/custom-gradient-picker/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ $components-custom-gradient-picker__padding: $grid-unit-20; // 48px container, 1
// Same size as the .components-custom-gradient-picker__control-point-dropdown parent
height: inherit;
width: inherit;
min-width: $grid-unit-20;
min-width: $grid-unit-20 !important;
border-radius: $radius-round;

background: $white;
Expand Down
Loading