PostTitle: exit early when post type doesn't support titles #67086
+19
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsnajdr
added
[Type] Bug
|
Size Change: +49 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @mijan-xs. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
cbravobernal
added
the
Backport to WP Minor Release
cbravobernal
pushed a commit
that referenced
this pull request
Nov 22, 2024
Unlinked contributors: mijan-xs. Co-authored-by: jsnajdr <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: Tropicalista <[email protected]>
|
Cherry-picked to be in a future 6.7.2 to fix #64814 |
cbravobernal
removed
the
Backport to WP Minor Release
aaronjorbin
added a commit
to aaronjorbin/wordpress-develop
that referenced
this pull request
Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs: - PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086 - Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244 - Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508 - [6.7] Zoom in/out to correct location WordPress/gutenberg#66618 - Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258 - Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259 - Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121 - [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503 - iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713 - e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886 - Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s - useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200 Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: DAreRodz <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Jarda Snajdr <[email protected]> Co-authored-by: Lena Morita <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: Mayank-Tripathi32 <[email protected]> Co-authored-by: PARTHVATALIYA <[email protected]> Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: Tropicalista <[email protected]> Co-authored-by: aaronjorbin <[email protected]> Co-authored-by: ajlende <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: danielpost <[email protected]> Co-authored-by: dcalhoun <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: im3dabasia <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: jsnajdr <[email protected]> Co-authored-by: mcsf <[email protected]> Co-authored-by: michalczaplinski <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: mt8 <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: sathyapulse <[email protected]> Co-authored-by: sirreal <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: youknowriad <[email protected]>
aaronjorbin
added a commit
to aaronjorbin/wordpress-develop
that referenced
this pull request
Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs: - PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086 - Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244 - Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508 - [6.7] Zoom in/out to correct location WordPress/gutenberg#66618 - Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258 - Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259 - Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121 - [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503 - iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713 - e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886 - Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s - useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200 Co-authored-by: Aki Hamano <[email protected]> Co-authored-by: DAreRodz <[email protected]> Co-authored-by: David <[email protected]> Co-authored-by: Ella <[email protected]> Co-authored-by: Jarda Snajdr <[email protected]> Co-authored-by: Lena Morita <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: Mayank-Tripathi32 <[email protected]> Co-authored-by: PARTHVATALIYA <[email protected]> Co-authored-by: Riad Benguella <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: Tropicalista <[email protected]> Co-authored-by: aaronjorbin <[email protected]> Co-authored-by: ajlende <[email protected]> Co-authored-by: cbravobernal <[email protected]> Co-authored-by: danielpost <[email protected]> Co-authored-by: dcalhoun <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: im3dabasia <[email protected]> Co-authored-by: jameskoster <[email protected]> Co-authored-by: jeryj <[email protected]> Co-authored-by: jsnajdr <[email protected]> Co-authored-by: mcsf <[email protected]> Co-authored-by: michalczaplinski <[email protected]> Co-authored-by: mirka <[email protected]> Co-authored-by: mt8 <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: sathyapulse <[email protected]> Co-authored-by: sirreal <[email protected]> Co-authored-by: stokesman <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: youknowriad <[email protected]>
pento
pushed a commit
to WordPress/wordpress-develop
that referenced
this pull request
Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs: - PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086 - Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244 - Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508 - [6.7] Zoom in/out to correct location WordPress/gutenberg#66618 - Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258 - Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259 - Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121 - [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503 - iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713 - e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886 - Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s - useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200 Reviewed-by audrasjb. Props 0mirka00, ajlende, cbravobernal, czapla, danielpost, darerodz, dpcalhoun, ellatrix, fabiankaegy, get_dave, gziolo, im3dabasia1, jameskoster, jeryj, jonsurrell, jorbin, jsnajdr, mamaduka, mayanktripathi32, mcsf, mt8biz, ndiego, parthvataliya, presstoke, santosguillamot, sathyapulse, tropicalista, tyxla, wildworks, youknowriad. Fixes #62889. git-svn-id: https://develop.svn.wordpress.org/branches/6.7@59762 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith
pushed a commit
to markjaquith/WordPress
that referenced
this pull request
Feb 4, 2025
Syncs Editor packages for WordPress 6.7.2 RC1. Includes the following PRs: - PostTitle: exit early when post type doesn't support titles WordPress/gutenberg#67086 - Patterns: receive intermediate responses while unbound request is resolving WordPress/gutenberg#66713 WordPress/gutenberg#67244 - Fix: Show Meta Boxes at the bottom of the screen regardless of the current rendering mode WordPress/gutenberg#66508 - [6.7] Zoom in/out to correct location WordPress/gutenberg#66618 - Composite: Restore Hover and Typeahead functionality - Backport to 6.7.2 WordPress/gutenberg#67258 - Interactivity API: fix property modification backport to 6.7.2 WordPress/gutenberg#67259 - Fix unexpected unlock control in block toolbar in non-default editing mode WordPress/gutenberg#67121 - [WP 6.7] Fix meta boxes saving when they’re not present WordPress/gutenberg#67503 - iAPI: Fix the logic path that merges plain objects - Backport to 6.7.2 WordPress/gutenberg#68713 - e2e:fix WP Editor Meta Boxes test WordPress/gutenberg#68886 - Keep meta boxes unsplit from content in device preview https://github.com/WordPress/gutenberg/pull/68902s - useFocusReturn: Get active element within the iframe when restoring focus WordPress/gutenberg#68060 WordPress/gutenberg#68200 Reviewed-by audrasjb. Props 0mirka00, ajlende, cbravobernal, czapla, danielpost, darerodz, dpcalhoun, ellatrix, fabiankaegy, get_dave, gziolo, im3dabasia1, jameskoster, jeryj, jonsurrell, jorbin, jsnajdr, mamaduka, mayanktripathi32, mcsf, mt8biz, ndiego, parthvataliya, presstoke, santosguillamot, sathyapulse, tropicalista, tyxla, wildworks, youknowriad. Fixes #62889. Built from https://develop.svn.wordpress.org/branches/6.7@59762 git-svn-id: http://core.svn.wordpress.org/branches/6.7@59104 1a063a9b-81f0-0310-95a4-ce76da25c4cd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64814, my debugging notes are in #64814 (comment)
When the post type doesn't support
title, exit early from rendering thePostTitlecomponent. The previous version was setting up all the hooks and whistles needed to render it, but in the end it didn't render theh1element.The patched version calls
useRichTextand everything else only when the post type support is really there.Note that this patch is merely working around what I believe is a bug in
useRichText: theuseRichTexthook fails in a subtle way when no element is rendered with therefthat it returns.This patch fixes the bug for me.