Inserter: Add 'Starter Content' category to the inserter #66819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +86 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
This also depends on other factors like the
The new category is not showing on the Site Editor > Patterns screen. |
Should it show there too? I guess this could be a follow-up. It would be nice if you can filter patterns in data views by block type. |
youknowriad
reviewed
Nov 11, 2024
| ) { | ||
| return true; | ||
| } | ||
|
|
There was a problem hiding this comment.
It's not great that the categorization logic is duplicated in two components. Feels like something that can be factorized. Maybe within use-patterns-state
|
Let's try it, and see if this can replace the modal in #66836. |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…6819) Co-authored-by: ellatrix <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: carolinan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Adds a new "Starter Content" category to the inserter, which contains patterns for the post content.
Why?
Currently, there is a modal showing on empty pages with starter content/patterns. After picking one of these, or closing the modal, it's no longer possible to find these patterns.
This PR adds a new category to the inserter, so they can be found once the modal is closed.
The grander goal is to eventually open this inserter category instead of the modal when a new page is created, but let's start small! See #61489.
How?
Just adds a new special category, and its filter.
Testing Instructions
Open a page, then open the inserter and this new category.
Testing Instructions for Keyboard
Screenshots or screencast