Modal: Increase size of the Close button #66792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
added
[Focus] Accessibility (a11y)
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 2ca94dc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11704107697
|
mirka
reviewed
Nov 13, 2024
There was a problem hiding this comment.
I'm going to tag @WordPress/gutenberg-design for review in case there are other considerations, since the close button size was already spec'ed in the Figma. (Designers: Please also confirm what the spacing should be between the header buttons.)
Code changes look good, and I'm ok with these changes as long as there were no other design considerations for the button size. If there were other considerations, we can weigh that against having a larger target size, since the current size technically already meets WCAG AA.
That is the whole point of this PR. As explained in #66758 WordPress should not aim for just the mimimum technical compliance. Whenever possible, when there is enough space, the target size should be reasonably bigger than the minimum required of 24 pixels. Aiming for only the minimum requirement is an approach that relegates accessibility to a remediation level, while WordPress should aim to provide the best experience for all users instead. |
afercia
force-pushed
the
fix/modal-x-close-button-size
branch
from
2ca94dc to
7674ff6
Compare
|
I tend to agree, there's adequate space to use a larger button, and not much justification for using the smallest variant imo. |
afercia
force-pushed
the
fix/modal-x-close-button-size
branch
from
7674ff6 to
85c5df7
Compare
|
Thanks @jameskoster for your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #66758
Note: as done for the previous change in #65131, I guess this will warrant a dev note.
What?
While using one of the new button size variants makes totally sense, the new 'small' size of 24 pixels is unnecessarily too small.
Why?
The target size of any interactive control should be as big as possible for better usability and accessibility.
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast
Highlighting the buttons with a red background to better illustrate:
Before:
After: