NumberControl: Deprecate 36px default size #66730
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…omponent to use __next40pxDefaultSize for NumberControl
|
Hi @mirka, I have updated the PR with suggestions and feedbacks on the previous PRs, Can you please have a review for the same. Also, I have looked in codebase regarding NumberControl usage in components, I have updated wherever I could find them. Let me know if there is any missing, I can update that as well. Thank You 🙇. |
mirka
added
[Type] Code Quality
# Conflicts: # packages/components/CHANGELOG.md
|
Hi @mirka, All the issues have been addressed. Thank You, |
* Add the deprecation for 36px default size to number control * Add the changelog for the deprecation * Update unit test and supress warning for 40px default size warning from child component * Add the deperection changelog to unreleased section and updated the component to use __next40pxDefaultSize for NumberControl * Refactor the test for NumberControl component to reduce changes * Update box control files to use supress warning prop before default 40px prop * Supress the console warning for deprecation message from child component * Addressed the feedbacks on the PR and updated the component based on that --------- Co-authored-by: hbhalodia <[email protected]> Co-authored-by: mirka <[email protected]>
* Add the deprecation for 36px default size to number control * Add the changelog for the deprecation * Update unit test and supress warning for 40px default size warning from child component * Add the deperection changelog to unreleased section and updated the component to use __next40pxDefaultSize for NumberControl * Refactor the test for NumberControl component to reduce changes * Update box control files to use supress warning prop before default 40px prop * Supress the console warning for deprecation message from child component * Addressed the feedbacks on the PR and updated the component based on that --------- Co-authored-by: hbhalodia <[email protected]> Co-authored-by: mirka <[email protected]>
Part of #65751
What?
Deprecate the 36px default size on NumberControl.
Testing Instructions
__next40pxDefaultSizeprop enabled