Convert lock unlock to generics

[manzoorwanijk]

What?

Addresses the feedback given in #66667 (comment)

Why?

To allow better type support for lock and unlock functions

How?

This PR makes lock and unlock as generics to set the object type

Testing Instructions

• Same as TypeScript: Fix and improve types for private-apis #66667

Testing Instructions for Keyboard

Screenshots or screencast

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: manzoorwanijk <[email protected]>
Co-authored-by: youknowriad <[email protected]>
Co-authored-by: jsnajdr <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[manzoorwanijk]

@jsnajdr Should I fix those types that are affected by the updated signature?

There are 7 errors in total, fixable by 3-4 minor changes

[manzoorwanijk]

@jsnajdr this one addresses your feedback given in #66667 (comment).

Can we get this through?

[youknowriad]

Works for me. I'd appreciate @jsnajdr's thoughts too.

[jsnajdr]

Yes this looks good. We don't have any real-world usages of the types yet, so we are not sure that they are the correct ones, but we can patch that when some problem is uncovered.

[manzoorwanijk]

Thank you folks. I can't merge PRs here. Please go ahead whenever you want.

[tyxla]

Thanks @manzoorwanijk, this looks great! I'll get it shipped 🚀