-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Style engine: wrap array_merge in conditionals to prevent unnecessary merging #66661
Conversation
Wrap array_merge in a conditional to prevent unnecessary firing.
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Flaky tests detected in 3d3a554. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11624372578
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
✅ Code changes match core PR
✅ Tests pass locally
✅ Smoke tested style engine manually and didn't spot any issues
Thanks for the thorough testing! |
… merging (WordPress#66661) Wrap array_merge in a conditional to prevent unnecessary firing. Co-authored-by: ramonjd <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
Applied to core in https://core.trac.wordpress.org/changeset/59442 |
Backport changes from Core patch: WordPress/wordpress-develop#7670
Wrap
array_merge
in a conditional to prevent unnecessary firing.Props to @mukeshpanchal27
Testing
CI tests should pass