Prevent duplicate post format taxonomy queries #66627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an early return to gutenberg_add_format_query_vars_to_query_loop_block if the taxonomy query already includes post formats.
carolinan
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
approved these changes
Oct 31, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Add an early return to gutenberg_add_format_query_vars_to_query_loop_block if the taxonomy query already includes post formats. Co-authored-by: carolinan <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: david-binda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
If Gutenberg is active on WordPress 6.7 or later, the filter that adds the post format to the taxonomy query should not run twice.
This PR adds an early return to gutenberg_add_format_query_vars_to_query_loop_block if the post format is already in the taxonomy query.
Closes #66071
Testing Instructions
I tested this by doing the following:
First I activated Gutenberg with this PR on WordPress 6.7 nightly.
I created a post with a post format and set the query loop to show this format.
Then I edited
gutenberg_add_format_query_vars_to_query_loop_blockand added a temporaryechoinside the new if-statement, to confirm that the early return was triggered on the front of the website.I also confirmed that the correct post was still shown.
Then I ran the Gutenberg PHP tests without issues. I have not ran the core tests!
Then I activated Gutenberg with the PR on WordPress 6.6.2 and re-did the manual test of the query loop with the post format filter applied, and confirmed that the filter still worked.