Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.7] Zoom in/out to correct location #66618

Merged
merged 30 commits into from
Nov 24, 2024
Merged

[6.7] Zoom in/out to correct location #66618

merged 30 commits into from
Nov 24, 2024

Commits on Oct 30, 2024

  1. Midway commit. Scaling out is broken

    @jeryj
    jeryj committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    b0d073a View commit details
    Browse the repository at this point in the history

  2. Fix zoom in animation

    @jeryj
    jeryj committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    122790d View commit details
    Browse the repository at this point in the history

  3. Fix scaling by preserving CSS properites

    @jeryj
    jeryj committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    1dedf7a View commit details
    Browse the repository at this point in the history

  4. Prevent reflow from removing and re adding scrollbar in animation

    @jeryj
    jeryj committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    114e23b View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Only rerun zoom out use effects if zoom out has changed.

    @jeryj
    jeryj committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    39eb8dd View commit details
    Browse the repository at this point in the history

  2. Allow all CSS vars to update when scale changes

    @jeryj
    jeryj committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    d08a6f6 View commit details
    Browse the repository at this point in the history

  3. Midway commit. Math is wrong for addressing top/bottom exceptions

    @jeryj
    jeryj committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    046902a View commit details
    Browse the repository at this point in the history

  4. Remove usePrevious usage

    @ajlende
    ajlende committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    ab88dfa View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Add prefers-reduced-motion to setTimeout delay

    @ajlende
    ajlende committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    be9ade9 View commit details
    Browse the repository at this point in the history

  2. WIP Working zoom without frame size

    @ajlende
    ajlende committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9f2d384 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Account for changes to client height when determining edge threshold

    @jeryj
    jeryj committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c4f97ba View commit details
    Browse the repository at this point in the history

  2. Zoom to center unless it will reveal top or bottom

    @jeryj
    jeryj committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    8bc12b2 View commit details
    Browse the repository at this point in the history

  3. Account for a top threshold when zooming in and out

    @jeryj
    jeryj committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    fffc48d View commit details
    Browse the repository at this point in the history

  4. Clean up math and add comments

    @ajlende
    ajlende committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    42dd030 View commit details
    Browse the repository at this point in the history

  5. Add event listener instead of timeout

    @ajlende
    ajlende committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    5fff8f9 View commit details
    Browse the repository at this point in the history

  6. Fix reduced motion

    @ajlende
    ajlende committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    c182b70 View commit details
    Browse the repository at this point in the history

  7. Remove timeout ref

    @ajlende
    ajlende committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    a9211e7 View commit details
    Browse the repository at this point in the history

  8. Refactor callback as separate effect

    @ajlende
    ajlende committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    6c91090 View commit details
    Browse the repository at this point in the history

  9. Fix JSDoc comment

    @ajlende
    ajlende committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    615f2b3 View commit details
    Browse the repository at this point in the history

  10. Try to add back useEffect cleanups

    @ajlende
    ajlende committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    907dde4 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2024

  1. Initialize prevClientHeight in the useEffect

    @ajlende
    ajlende committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    fe8fd4e View commit details
    Browse the repository at this point in the history

  2. use useReducedMotion

    @jeryj
    jeryj committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    624be01 View commit details
    Browse the repository at this point in the history

  3. Add test for zoom in/out location

    @jeryj
    jeryj committed Nov 7, 2024
    Configuration menu
    Copy the full SHA
    b9eb0d2 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2024

  1. Hack to fix reduced motion

    @ajlende
    ajlende committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    d51db38 View commit details
    Browse the repository at this point in the history

  2. Clean up the frameSizeValue and scaleValue calculations

    @ajlende
    ajlende committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    1e7f1ee View commit details
    Browse the repository at this point in the history

  3. Replace TODO comments with HACK comments

    @ajlende
    ajlende committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    740cd9a View commit details
    Browse the repository at this point in the history

  4. Add cleanup for raf

    @ajlende
    ajlende committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    37111fa View commit details
    Browse the repository at this point in the history

  5. Simplify CSS diff for 6.7 review

    @ajlende
    ajlende committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ce8665d View commit details
    Browse the repository at this point in the history

  6. Add one more HACK comment

    @ajlende
    ajlende committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    ab31e44 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2024

  1. Do not allow scrollTopNext to be smaller than 0

    @jeryj
    jeryj committed Nov 11, 2024
    Configuration menu
    Copy the full SHA
    0b4d86d View commit details
    Browse the repository at this point in the history