Global styles: preload user global styles based on user caps #66541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramonjd
added
[Type] Performance
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ramonjd
force-pushed
the
update/global-styles-preload-paths-remove-6.6-compat
branch
from
a0d5912
to
4dfc9bb
Compare
ellatrix
reviewed
Oct 29, 2024
ellatrix
reviewed
Oct 29, 2024
ellatrix
reviewed
Oct 29, 2024
ramonjd
force-pushed
the
update/global-styles-preload-paths-remove-6.6-compat
branch
from
a53ebf8
to
ead5d8b
Compare
|
Flaky tests detected in bace479. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11585143275
|
ramonjd
force-pushed
the
update/global-styles-preload-paths-remove-6.6-compat
branch
2 times, most recently
from
52173f5
to
58aa39f
Compare
ramonjd
commented
Oct 30, 2024
| @@ -60,6 +59,7 @@ function gutenberg_block_editor_preload_paths_6_7( $paths, $context ) { | |||
| $paths[] = array( '/wp/v2/global-styles/' . $global_styles_id, 'OPTIONS' ); | |||
|
|
|||
| // Remove duplicate or unnecessary global styles paths. | |||
| $excluded_paths = array(); | |||
There was a problem hiding this comment.
Unrelated, but just moving var assignment closer to where it's being used, inside the block.
aaronrobertshaw
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Thanks for following up on these @ramonjd 👍
This is testing as advertised for me.
✅ Admin user: global styles paths aren't requested client side, they're preloaded in both editors using edit context
✅ Non-admin user: global styles paths are preloaded as advertised using view context
✅ Previous feedback has been addressed
✅ Code changes look ok to me
I'm happy if Ella's happy with this 🙂
I'll be offline for a few days so in case it helps keeping this moving I'll drop an approval on it now.
ellatrix
reviewed
Oct 30, 2024
ellatrix
approved these changes
Oct 30, 2024
|
Thanks a lot for the quick reviews, folks! 🙇🏻 |
|
Size Change: 0 B Total Size: 1.81 MB ℹ️ View Unchanged
|
|
Fails are due to |
ramonjd
force-pushed
the
update/global-styles-preload-paths-remove-6.6-compat
branch
from
33bf722
to
6188e2c
Compare
…aps to prevent clientside request in post editor. Add explanatory comments in relevant files.
ramonjd
force-pushed
the
update/global-styles-preload-paths-remove-6.6-compat
branch
from
6188e2c
to
c7731bf
Compare
|
Oh! It needed a rebase after #66488 should be good now. |
ramonjd
deleted the
update/global-styles-preload-paths-remove-6.6-compat
branch
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…ss#66541) This commit preloads '/wp/v2/global-styles/' . $global_styles_id with a context corresponding to user caps, that is, edit for users that can edit global styles, and view for everyone else. Preloading the global styles endpoint according to role context means that admins and non admins, e.g., editors, avoid clientside requests. Co-authored-by: ramonjd <[email protected]> Co-authored-by: ellatrix <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow up to:
This PR preloads
'/wp/v2/global-styles/' . $global_styles_idwith a context corresponding to user caps, that is,editfor users that can edit global styles, andviewfor everyone else.Why?
Preloading the global styles endpoint according to role context means that admins and non admins, e.g., editors, avoid clientside requests.
Different clientside requests fire for each.
How?
Use
current_user_can( 'edit_theme_options' )to test for global styles edit caps. This matches post type caps.Testing Instructions
global-stylesendpoints aren't fetched client side, but are, rather, preloaded via rest_preload_api_requestFor admins in the POST and SITE editors the following URLS should be preloaded:
For editors in the POST editor: