Compose: Fix React Complier error for 'useCopyToClipboard' #66444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +3 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
youknowriad
reviewed
Oct 25, 2024
| @@ -20,7 +20,9 @@ import useRefEffect from '../use-ref-effect'; | |||
| */ | |||
| function useUpdatedRef( value ) { | |||
There was a problem hiding this comment.
I think the need for this hook can probably be removed entirely and replaced with useEvent
There was a problem hiding this comment.
That would work for onSuccess, but not with text since it can be string|callback and the useEvent always expected callback.
There was a problem hiding this comment.
It would work for both because onSuccess will just be using the latest "text" there's no need for hook around text.
There was a problem hiding this comment.
Actually you maybe right here, text seems to be used outside of the event handler, (within the refEffect).
youknowriad
approved these changes
Oct 25, 2024
|
Thanks, Riad! |
swissspidy
pushed a commit
that referenced
this pull request
Oct 25, 2024
Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]>
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…#66444) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: youknowriad <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Part of #61788.
PR fixes the React Compiler error for the
useCopyToClipboardhook.Why?
It's recommended to avoid reading/writing refs during the render.
How?
Correctly implement the latest ref pattern.
Testing Instructions
Testing Instructions for Keyboard
Same.