Re-order spacing side controls when unlinked #66317
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madhusudhand
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
@richtabor While the link icon can be rotated using CSS, I think it is best to update the SVG. Could you provide vertically aligned Link and unlink svg asset? |
|
Size Change: -1 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
mikachan
reviewed
Oct 31, 2024
There was a problem hiding this comment.
These changes test well for me 👍
It looks like the static linting test is failing but I don't think it's related to these changes, this probably just needs a rebase.
While the link icon can be rotated using CSS, I think it is best to update the SVG. Could you provide vertically aligned Link and unlink svg asset?
For this, is sides-vertical helpful?
madhusudhand
force-pushed
the
reorder-spacer-sides
branch
from
91e40ba to
90d29f6
Compare
I think the sides icons are already updated with respective sides. The current PR updates their order. 
Also, the vertical link icons are created by duplicating their horizontal versions (duplicated because these icons are also used in other instances). I choose to rotate the icons. Alternatively the CSS rotation can be applied to the link button itself, so that icon duplication can be avoided. I am going to test if this has any acceptability implications. |
|
Flaky tests detected in e49db30. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12461989906
|
madhusudhand
force-pushed
the
reorder-spacer-sides
branch
from
90d29f6 to
1088d85
Compare
@richtabor Could you provide your feedback on this change? |
|
Let's just do the order change, instead of the icon changes. We can push those into a separate PR, as they're more subjective. |
madhusudhand
force-pushed
the
reorder-spacer-sides
branch
from
1088d85 to
e49db30
Compare
👍 This PR includes only order change. Icon change will be addressed in a followup PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This change is from the suggestions from this comment
Testing Instructions
Verify spacing controls (padding, margin) in styles panel. Now they should be in the following order.
Top,bottom,left,rightwhen unlinked.Top + bottom,Left + Rightwhen linked.