ColorPalette: Prevent overflow of custom color button background #66152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Bug
t-hamano
changed the title
t-hamano
changed the title
t-hamano
changed the title
|
Size Change: +21 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
color-palette/background-overflow
branch
from
8b69bdf
to
3439858
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
commented
Oct 16, 2024
tyxla
approved these changes
Oct 16, 2024
|
Flaky tests detected in 3d2b24d. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11381692387
|
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
…dPress#66152) * ColorPalette: Prevent overflow of custom color button background * Update changelog * Use variable instead of hardcoded value * Update packages/components/src/color-palette/style.scss Co-authored-by: Marco Ciampini <[email protected]> * Fix changelog entry --------- Co-authored-by: t-hamano <[email protected]> Co-authored-by: tyxla <[email protected]> Co-authored-by: ciampo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes two issues with the custom color buttons in the color palette buttons:
Why? / How?
As for the corner overflow, it became more noticeable after the radius value was changed from 2px to 4px in #64368.
As for the overlap with the border, I think it looks more natural to shift it by 1px to avoid overlapping.
Testing Instructions
Visit http://localhost:50240/?path=/docs/components-colorpalette--docs and check the corners of the component.
Screenshots or screencast
Before
After