Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: Consistent external media pre-publish image/button sizes #65668

Merged
merged 1 commit into from
Sep 26, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why we use inline styles, but that's something for another PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, it was unexpected.

Original file line number Diff line number Diff line change
Expand Up @@ -98,8 +98,8 @@ function Image( { clientId, alt, url } ) {
animate={ { opacity: 1 } }
exit={ { opacity: 0, scale: 0 } }
style={ {
width: '36px',
height: '36px',
width: '32px',
height: '32px',
objectFit: 'cover',
borderRadius: '2px',
cursor: 'pointer',
Expand Down Expand Up @@ -256,7 +256,7 @@ export default function MaybeUploadMediaPanel() {
<Spinner />
) : (
<Button
__next40pxDefaultSize
size="compact"
variant="primary"
onClick={ uploadImages }
>
Expand Down
Loading