-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Widget Editor: Fix: close button is not working #65443
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @parthVataliya16. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @PARTHVATALIYA! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and it works, let's 🚢 it!
Thanks @PARTHVATALIYA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @PARTHVATALIYA,
Sorry for the delay in reviewing this PR. Could you resolve the conflicts so we can ship this PR?
We should also be able to remove this CSS:
gutenberg/packages/edit-widgets/src/components/layout/style.scss
Lines 10 to 15 in 9e3bdeb
.edit-widgets-layout__inserter-panel-header { | |
padding-top: $grid-unit-10; | |
padding-right: $grid-unit-10; | |
display: flex; | |
justify-content: flex-end; | |
} |
Hey @t-hamano, thank you for your response! 🙂 I have resolved all the conflicts and removed the unnecessary CSS. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the update 👍
* Fix: close button is not working * Remove unnecessary CSS --------- Unlinked contributors: parthVataliya16. Co-authored-by: PARTHVATALIYA <[email protected]> Co-authored-by: draganescu <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: miminari <[email protected]>
What?
Closes #65433
Why?
Bug fix.
How?
Adding
onClose
props to close buttonTesting Instructions
Screenshots or screencast
Themes.gutenberg.WordPress.webm