Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget Editor: Fix: close button is not working #65443

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

PARTHVATALIYA
Copy link
Contributor

@PARTHVATALIYA PARTHVATALIYA commented Sep 18, 2024

What?

Closes #65433

Why?

Bug fix.

How?

Adding onClose props to close button

Testing Instructions

  • Activate the twenttwentyone theme
  • Open appearnce > widgets
  • Open block inserter
  • Click on close button on the inserter menu and it should close
  • Change the responsive view to tablet view
  • Open block inserter
  • There is no one extra close button for closing inserter menu

Screenshots or screencast

Themes.gutenberg.WordPress.webm

Copy link

github-actions bot commented Sep 18, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @parthVataliya16.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: parthVataliya16.

Co-authored-by: PARTHVATALIYA <[email protected]>
Co-authored-by: draganescu <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: miminari <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 18, 2024
Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @PARTHVATALIYA! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

Copy link
Contributor

@draganescu draganescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it works, let's 🚢 it!
Thanks @PARTHVATALIYA

@draganescu draganescu added [Type] Bug An existing feature does not function as intended [Package] Edit Widgets /packages/edit-widgets labels Sep 24, 2024
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @PARTHVATALIYA,

Sorry for the delay in reviewing this PR. Could you resolve the conflicts so we can ship this PR?

We should also be able to remove this CSS:

.edit-widgets-layout__inserter-panel-header {
padding-top: $grid-unit-10;
padding-right: $grid-unit-10;
display: flex;
justify-content: flex-end;
}

@PARTHVATALIYA
Copy link
Contributor Author

Hey @t-hamano, thank you for your response! 🙂

I have resolved all the conflicts and removed the unnecessary CSS.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the update 👍

@t-hamano t-hamano changed the title Fix: close button is not working Widget Editor: Fix: close button is not working Dec 12, 2024
@t-hamano t-hamano merged commit 0ef8a35 into WordPress:trunk Dec 12, 2024
62 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 12, 2024
yogeshbhutkar pushed a commit to yogeshbhutkar/gutenberg that referenced this pull request Dec 18, 2024
* Fix: close button is not working

* Remove unnecessary CSS

---------

Unlinked contributors: parthVataliya16.

Co-authored-by: PARTHVATALIYA <[email protected]>
Co-authored-by: draganescu <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: miminari <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Package] Edit Widgets /packages/edit-widgets [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Close button is not working in block inserter menu inside widget editor.
4 participants