ESLint: Fix temp migration rules for the components package #65270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
|
@mirka: most of the errors are in tests or stories, but still, there are a few that occur in the components themselves. Do we have a plan for those? I'm assuming this might be intentional, but still, wanted to confirm before starting to work on fixing them. If it wasn't intentional and want to fix them, we might need to work on a plan like #65018. |
|
Size Change: 0 B Total Size: 1.81 MB ℹ️ View Unchanged
|
|
Flaky tests detected in fceabc5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11562688457
|
tyxla
force-pushed
the
enable/prop-migration-rules-components-package
branch
from
359d0ed
to
ab19dc2
Compare
|
With #65018 now complete, I think it's time to move this PR forward. @WordPress/gutenberg-components |
|
@t-hamano noting that this will involve a careful case-by-case consideration, which is likely to take lots of time. Many of the existing instances might be using a component intentionally without specifying a size. Some might need to use a different solution (like |
|
Just to understand — if the purpose of this PR was just to re-introduce ESLint rules that were accidentally overwritten, couldn't just do that and then move to a separate issue to dicuss each migration option? |
|
@ciampo @t-hamano just to clarify: the purpose of this PR is not to land it. As we addressed all I agree the best next step is to create a tracking issue and start auditing and/or addressing them all, one by one, in separate PRs. I'm just a bit swamped with other things right now, but happy to assist with anything if anyone wants to take over. Note: we should probably do another run of this with an up-to-date |
|
Thank you for the clarification, Marin. Agree on the whole line |
|
I'm also expecting a lot of this to be resolved through the work in #65751. |
mirka
force-pushed
the
enable/prop-migration-rules-components-package
branch
from
ab19dc2
to
fceabc5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Enable the temp prop migration rules for the component package.
Why?
They appear to have been unintentionally overwritten and didn't work for the components package.
See #65018 (comment)
How?
Moving the rules and reusing them where necessary.
Testing Instructions
no-restricted-syntaxerrors in this branch.Testing Instructions for Keyboard
None
Screenshots or screencast