Build: Stop generating unused legacy scripts for core blocks #65268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +40 B (0%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
Intriguing, it looks like the Form block uses a regular script ... I need to revisit this PR then. Plus, it apparently depends on #65232 as the zip file generation files because files are missing for core blocks in the |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I think this is blocking #65926. One idea for packages like this is to use an There was also work in #65064 that added a script modules exports field, another option would be to exclude files that appear there. |
gziolo
force-pushed
the
update/obsolete-block-build-artifacts
branch
from
0d065c7 to
d988d70
Compare
In d988d70 I refactored the view file for Form block to work as a script module. |
gziolo
added
[Type] Code Quality
|
This is ready for review and testing. I included the testing instructions for the Form block, which is a bit more work to verify. |
|
Flaky tests detected in d988d70. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12116288266
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Follow-up for #65064.
From #65064 (comment):
Why?
How?
Basically remove all related entry points and corresponding logic and config options.
These changes apply to the following blocks:
There will be present moving forward in
build-module/block-libraryonly.Screenshots or screencast
After:
Testing instructions for Form block
Fill in the form data:
Send the form and check the success message: