Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong npm start command #65221

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Fix wrong npm start command #65221

merged 1 commit into from
Dec 23, 2024

Conversation

rilwis
Copy link
Contributor

@rilwis rilwis commented Sep 11, 2024

This PR just fix the wrong npm start command in the docs. Currently, it's npm run start where it should be npm start.

Copy link

github-actions bot commented Sep 11, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: rilwis <[email protected]>
Co-authored-by: ndiego <[email protected]>
Co-authored-by: juanmaguitar <[email protected]>
Co-authored-by: gziolo <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @rilwis! In case you missed it, we'd love to have you join us in our Slack community.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

@github-actions github-actions bot added the First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository label Sep 11, 2024
Copy link
Member

@ndiego ndiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

npm start does technically work, but for consistency with npm run build, I do think npm run start is better for new users.

@ndiego ndiego added the [Type] Developer Documentation Documentation for developers label Sep 11, 2024
@juanmaguitar
Copy link
Contributor

juanmaguitar commented Sep 11, 2024

As this is meant to be an introductory guide for using JavaScript in WordPress, I think we should reference both npm run start and npm start.
What about something like?

  • **Development Mode (npm run start or just npm start)

@ndiego
Copy link
Member

ndiego commented Sep 11, 2024

As this is meant to be an introductory guide for using JavaScript in WordPress, I think we should reference both npm run start and npm start.
What about something like?

**Development Mode (npm run start or just npm start)

➕ Good call

@gziolo
Copy link
Member

gziolo commented Dec 23, 2024

npm start is the first thing you learn when interacting with JavaScript projects so I guess it's better to use that form as proposed in this PR.

@gziolo gziolo merged commit c979084 into WordPress:trunk Dec 23, 2024
56 of 68 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.0 milestone Dec 23, 2024
@rilwis rilwis deleted the patch-1 branch December 24, 2024 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
First-time Contributor Pull request opened by a first-time contributor to Gutenberg repository [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants