Fix error and improve privacy of sectionRootClientId setting #65000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
getdave
added
[Type] Code Quality
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -1 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
getdave
requested review from
scruffian,
talldan,
jeryj,
MaggieCabrera and
tjcafferkey
|
Flaky tests detected in 68315a3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10682296598
|
getdave
deleted the
try/use-private-symbol-key-for-section-root-client-id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes an error caused by usage of
unlockaroundgetSettingswhen accessing thesectionRootClientIdsetting.Related to #65001
Resolves #64141
Co-authored-by: Daniel Richards [email protected]
Why?
The method used to make the setting private was suboptimal and caused errors.
How?
Updates to use a Symbol (hat tip @talldan) to represent the setting key. We then make the key a private API and consume it as required to access the setting.
A separate PR will normalise all this into a single private selector to avoid having to import the private key everywhere.
Testing Instructions
Follow same instructions as #64544
Testing Instructions for Keyboard
Screenshots or screencast