DataViews Quick Edit: Add the PostActions dropdown menu #64393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
[Type] Experimental
youknowriad
requested review from
oandregal,
jameskoster,
jorgefilipecosta and
ntsekouras
youknowriad
requested review from
ajitbohra,
ryanwelcher,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
Size Change: -23 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Flaky tests detected in ee5d7fb. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10317275136
|
|
Are actions declared by post type (and hence they all appear in all the places)? or can the list of actions be different depending on the context? Not a blocker, but I find it weird that there's an action for "rename" when you can edit the title directly: 
|
oandregal
approved these changes
Aug 9, 2024
Yes, per post type and selected item. What do you mean by "context"? |
Context as the place where actions are displaed: quick edit, document inspector, dataviews, etc. As I mentioned, I find the rename action weird in the context of the quick edit form and the DocumentInspector, where you can edit the title directly. |
I had added this in our API for revisions action |
|
We have "context" support. I'm still not entirely convinced by it personally though. If an action is specific to a given context maybe it should just be defined for that specific |
I see. Perhaps we just need to make actions a prop of DataForm, like they are in DataViews. |
We could remove the const postActions = usePostActions();
const actions = postActions.filter( /* all but rename */ );
<DataForm
actions={actions}
/>but even that would be fragile. I understand there's a hook for 3rd parties to add/remove new actions to the post type? If so, hiding/removing becomes more complex. |
|
Allowing-third parties to remove/add contextual actions is a good point about keeping the context property. |
getdave
pushed a commit
that referenced
this pull request
Aug 14, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: oandregal <[email protected]> Co-authored-by: ntsekouras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #55101
Follow-up to #64365
What?
This PR adds the "Actions" dropdown menu to the quick edit panel.
Similar to the "Post Card", this only works for single selections for now.
Testing Instructions
1- Enable the quick edit experiment and open the pages "table" data view.
2- Select a page and notice that you can use the actions dropdown menu from the quick edit panel.