Site Editor: Wrap each router area in 'ErrorBoundary' #64245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
Size Change: -205 B (-0.01%) Total Size: 1.83 MB
ℹ️ View Unchanged
|
|
I think we should probably have an |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Mamaduka
force-pushed
the
update/site-editor-lift-error-boundary
branch
from
cdbff5b to
0ca3565
Compare
|
@youknowriad updated the location again. |
youknowriad
reviewed
Aug 5, 2024
Mamaduka
force-pushed
the
update/site-editor-lift-error-boundary
branch
from
0ca3565 to
9496d64
Compare
Mamaduka
changed the title
|
The error boundary is now wrapped around router areas, but some design adjustments are needed. See the sidebar example. cc @WordPress/gutenberg-design |
|
Flaky tests detected in 9496d64. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12108792632
|
From a glance at the screenshot (if that's what you're referring to), indeed, though that's generic for anything using the error boundary. What's a good way to trigger an error outside the canvas? As for the error boundary itself, it seems like it could be closer to this:
That's in button, and notably margins/paddings. |
youknowriad
approved these changes
Dec 2, 2024
Mamaduka
force-pushed
the
update/site-editor-lift-error-boundary
branch
from
9496d64 to
d862ca1
Compare
|
It looks like the block editor's Screenshot
|
Mamaduka
commented
Dec 5, 2024
|
I pushed the following changes:
@jasmussen, do you mind smoke testing the updated design? Easiest way to do that is to comment out following lines: gutenberg/packages/editor/src/components/error-boundary/index.js Lines 57 to 59 in 9e76f0f Screenshots
|
|
Works as intended for me:
I think there's a design-system effort to decide how this kind of crash error message should look: at the moment it's not using any established patterns. Black border and a drop shadow. But that's separate, and this PR improves it. 👍 👍 |
|
Thanks for checking, @jasmussen!
Happy to follow-up on this. Just point me to the right direction :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
PR moves the Site Editor error boundary up to the React tree to catch errors for every route.
Why?
The error triggered outside the block editor canvas was causing a "grey screen of death".
Testing Instructions
/wp-admin/site-editor.php?postType=wp_template.Testing Instructions for Keyboard
Same.
Screenshots or screencast