DataViews: display published date for pages/posts with published status #64049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
oandregal
added
[Type] Bug
|
Size Change: +6 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
Good catch, this seems to be working for me. Here's a published page I updated just before switching to this branch: 
The label says 'Published', but the date is the modified date. Here's the same page on this PR: 
It's a separate issue, but it still feels a bit strange to me how the date 'types' are mixed for the purposes of sorting. Sorting published pages by modified date could be a nice feature. I wonder if it would make sense to split 'modified' and 'published' dates into separate fields in the future. |
oandregal
force-pushed
the
update/post-field-date-for-published-status
branch
from
0bb02f5 to
3d4f586
Compare
oandregal
commented
Jul 30, 2024
| getFormattedDate( dateToDisplay ) | ||
| /* translators: %s: page creation time */ | ||
| __( '<span>Published: <time>%s</time></span>' ), | ||
| getFormattedDate( item.date ) |
There was a problem hiding this comment.
This is the core change (dateToDisplay becomes item.date). The rest is due to moving isPublished logic before isPending.
As of this PR, all statuses but |
youknowriad
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #61709
What?
Display the published date for posts/pages with published status. Before it displayed the newest of modified and published date.
Why?
This is how other parts of the system work (wp-admin post/page list, post/page inspector). It's also how the REST API works, and by not using published date the sort results are visually incoherent with sorting.
In the example below, after installing the theme test data, I edited the "WP 6.1 font size scale" post. In wp-admin and dataviews sorted the list by date descending. This is how it looked everywhere:
How?
Updates the
renderfunction of thedatefield to use theitem.dateinstead ofitem.modifiedfor published posts/pages.Testing Instructions
The expected result is that "Post 2" is above "Post 1".
The expected result is that "Post 2" is still above "Post 1".