Grid Interactivity: Fix block mover layout and styles #64021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Type] Experimental
t-hamano
commented
Jul 27, 2024
Comment on lines
+72
to
+76
| if ( | ||
| ! canMove || | ||
| ( isFirst && isLast && ! rootClientId ) || | ||
| ( hideDragHandle && isManualGrid ) | ||
| ) { |
There was a problem hiding this comment.
Prevents a ToolbarGroup component that has no children from being rendered.
t-hamano
commented
Jul 27, 2024
| ); | ||
| } } | ||
| /> | ||
| <div className="block-editor-grid-item-mover__move-horizontal-button-container is-left"> |
There was a problem hiding this comment.
For the toolbar button, the ::before pseudo-element is used for the focus outline and the :::after pseudo-element is used for the text when "Show button text labels" is enabled.
I wrapped the button in a div to render a border as a pseudo-element.
t-hamano
commented
Jul 27, 2024
| @@ -105,7 +105,6 @@ | |||
| .block-editor-grid-item-mover-button { | |||
| width: $block-toolbar-height * 0.5; | |||
| min-width: 0 !important; // overrides default button width. | |||
| overflow: hidden; | |||
There was a problem hiding this comment.
To fix incorrect focus outline
t-hamano
commented
Jul 27, 2024
Comment on lines
+175
to
+184
| .editor-collapsible-block-toolbar { | ||
| .block-editor-grid-item-mover__move-vertical-button-container { | ||
| // Move up a little to prevent the toolbar shift when focus is on the vertical movers. | ||
| @include break-small() { | ||
| height: $grid-unit-50; | ||
| position: relative; | ||
| top: -5px; // Should be -4px, but that causes scrolling when focus lands on the movers, in a 60px header. | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Similar to this approach for the default block mover. the .editor-collapsible-block-toolbar selector is used to determine that the Top Toolbar is enabled.
t-hamano
commented
Jul 27, 2024
| @@ -208,5 +242,21 @@ | |||
| } | |||
| } | |||
|
|
|||
| .block-editor-grid-item-mover-button { | |||
| white-space: nowrap; | |||
There was a problem hiding this comment.
To prevent text wrapping when the "Show button text labels" is enabled
|
Size Change: +251 B (+0.01%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
noisysocks
approved these changes
Jul 30, 2024
|
I recently tidied up the list of tasks in #57478 if you'd like to keep working on Grid 😀 |
|
Thanks for the review!
I'll try to find a task that I can tackle 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64017
What?
This PR fixes the block movers layout and style when the experimental "Grid interactivity" setting is enabled and a grid block is in manual mode,
Why?
The core mover buttons determine their layout and style taking into account scenarios such as browser width, whether Top Toolbar is enabled, whether "Show button text labels" is enabled, etc. I believe similar logic is needed for the mover buttons for grid blocks.
How?
I applied the same logic as the core mover button, details are commented inline.
Testing Instructions
We need to test the following scenarios:
For each of these scenarios, make sure that:
Screenshots or screencast
Before
before.mp4
After
after.mp4