Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport docs: update and format #63830

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Backport docs: update and format #63830

merged 4 commits into from
Jul 23, 2024

Conversation

ramonjd
Copy link
Member

@ramonjd ramonjd commented Jul 23, 2024

What?

Updating docs surrounding backports and PHP changes.

Why?

The Gutenberg PHP doc was out of date given the backport change log process.

Also, I formatted and updated the examples for the backport change log process.

@ramonjd ramonjd added the [Type] Developer Documentation Documentation for developers label Jul 23, 2024
@ramonjd ramonjd self-assigned this Jul 23, 2024
@ramonjd ramonjd requested a review from spacedmonkey as a code owner July 23, 2024 03:10
Copy link

github-actions bot commented Jul 23, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: ramonjd <[email protected]>
Co-authored-by: andrewserong <[email protected]>
Co-authored-by: noisysocks <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@ramonjd ramonjd added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Jul 23, 2024
@ramonjd ramonjd requested review from ellatrix and andrewserong July 23, 2024 03:16
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a good change to me! Just pinging @noisysocks and @kevin940726 for visibility since they'll be the next release leads for 6.7 🙂

backport-changelog/readme.md Outdated Show resolved Hide resolved
If so, it is recommended to create a [new Trac ticket](https://core.trac.wordpress.org/newticket) and submit a pull request to the [WordPress Core GitHub repository](https://github.com/WordPress/wordpress-develop) soon after your pull request is merged.
For more information, please refer to the [Core backport changelog documentation](https://github.com/WordPress/gutenberg/tree/trunk/backport-changelog/readme.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like that this is linking to the other docs for the full set of instructions 👍

backport-changelog/readme.md Outdated Show resolved Hide resolved
Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, I meant to hit the Approve button on my comment earlier, so here you go! ✅

@noisysocks
Copy link
Member

Very nice thanks!

@ramonjd
Copy link
Member Author

ramonjd commented Jul 23, 2024

Thanks for checking, team!

@ramonjd ramonjd merged commit c7b263d into trunk Jul 23, 2024
63 of 64 checks passed
@ramonjd ramonjd deleted the update/php-backport-docs branch July 23, 2024 07:32
@github-actions github-actions bot added this to the Gutenberg 18.9 milestone Jul 23, 2024
@gziolo
Copy link
Member

gziolo commented Jul 30, 2024

That’s extremely helpful, thank you for contributing these documentation 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants