Footnotes: Register format within the init function #63554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -3 B (0%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
youknowriad
force-pushed
the
update/footnote-format-registration
branch
from
e22225b
to
9ed652a
Compare
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: youknowriad <[email protected]> Co-authored-by: ellatrix <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #51201 (comment)
Related #53874
What?
Some third-party editor uses the
@wordpress/block-librarypackage but only pick generic blocks from it. Things are WP specific like footnotes are not needed.The problem in trunk right now is that the "footnotes" format is registered as soon as you import the package regardless of whether you register the footnotes block or not which results in a 404 api request for all these editors.
This PR fixes that by moving the registration of the footnote format to the "init" function.
Testing Instructions
1- Check that footnotes still work in the post editor.
2- Check that when you type in the "storybook" example for block editors, you won't see any failed API request.