Commands: update cmdk #63465
Merged
Commands: update cmdk #63465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
[Focus] Accessibility (a11y)
|
Size Change: +867 B (+0.05%) Total Size: 1.75 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
reviewed
Jul 12, 2024
| 'aria-label', | ||
| __( 'Command suggestions' ) | ||
| ); | ||
| }, [ commandListRef.current ] ); |
afercia
reviewed
Jul 12, 2024
| @@ -287,7 +277,10 @@ export function CommandMenu() { | |||
| /> | |||
| <Icon icon={ inputIcon } /> | |||
| </div> | |||
| <Command.List ref={ commandListRef }> | |||
| <Command.List | |||
| ref={ commandListRef } | |||
There was a problem hiding this comment.
I think this ref can be removed now?
See also line 195.
There was a problem hiding this comment.
Nice catch! Indeed, the ref is no longer necessary. Deleted by 0a0ecc9
|
Nice clean up, thanks for taking care of this @t-hamano . |
scruffian
pushed a commit
that referenced
this pull request
Jul 15, 2024
* Commands: update cmdk * Remove unused ref Co-authored-by: t-hamano <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: afercia <[email protected]>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
* Commands: update cmdk * Remove unused ref Co-authored-by: t-hamano <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: afercia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59703
What?
This PR updates the command package cmdk from version
0.2.0to1.0.0.At the same time, it removes a temporary workaround for an issue that has been resolved upstream.
Why?
By updating cmdk to version
1.0.0, this temporary workaround is no longer necessary.How?
Regarding updating the npm packages, I followed the instructions in the article, but please let me know if I'm wrong.
packages/commands/package.jsonfile, I manually updated the version of thecmdkline to^1.0.0.npm installFor labels, I removed the temporary workaround code. Instead, I added a new
labelprop that the List component now supports.Testing Instructions
role="listbox"attribute should still have the labelCommand suggestions(I've simplified the code for easier reading).