Section Styles: Fix error when blocks are deregistered #63252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronrobertshaw
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +6 B (0%) Total Size: 1.76 MB
ℹ️ View Unchanged
|
t-hamano
approved these changes
Jul 8, 2024
|
Appreciate the lightning-fast review @t-hamano ⚡ Once the tests pass, I'll get this merged and address anything else in a further follow-up. |
aaronrobertshaw
deleted the
fix/section-styles-error-when-block-is-deregistered
branch
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Jul 8, 2024
Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: MadtownLems <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.6 branch to get it included in the next release: ed3f1d8 |
huubl
pushed a commit
to huubl/gutenberg
that referenced
this pull request
Jul 10, 2024
Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: MadtownLems <[email protected]>
carstingaxion
pushed a commit
to carstingaxion/gutenberg
that referenced
this pull request
Jul 18, 2024
Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: ndiego <[email protected]> Co-authored-by: MadtownLems <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #63208
What?
Adds optional chaining to retrieval of variation selectors to prevent an error and editor crash when a block has been deregistered via JS.
A better long-term fix will be to refactor the block style variations hook so that the block types and selectors retrieved there can't be stale. This PR is the quickest fix that addresses the issue in time for the final 6.6 RC. It will also make any future refactor more robust as well.
Props to @t-hamano for isolating the cause of the error 🙇
Why?
How?
.-->?.Testing Instructions
trunkcore/site-logo,core/imageetc.wp.blocks.unregisterBlockType( 'core/image' );Bonus Points
core/imageblockPHP group block style variation snippet
Screenshots or screencast
Screen.Recording.2024-07-09.at.12.34.24.AM.mp4
Screen.Recording.2024-07-09.at.12.35.15.AM.mp4